fix(LeftSidebar): remove unused NcListItem.isActive #10008
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
active
state ofNcListItem
link is controlled byRouterLink
since nextcloud-libraries/nextcloud-vue#3775So
NcListItem
doesn't useisActive
prop and we don't need to computeisActive
flag manually.Removing this computed also a very little bit decreases a number of re-renderings on each conversation switch (
Conversation.vue
is not re-rendering now, butNcListItem
is re-rendering anyway).🖼️ Screenshots
No visual changes
🚧 Tasks
NcListItem.isActive
isActive
computed🏁 Checklist
docs/
has been updated or is not required